Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -v|--version CLI tool argument #561

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix -v|--version CLI tool argument #561

merged 2 commits into from
Dec 12, 2024

Conversation

christianhelle
Copy link
Owner

This pull request includes changes to the src/Refitter/GenerateCommand.cs file to handle version flag arguments. The most important changes are:

  • Added a check in the Validate method to return success if the version flag (--version or -v) is present in the command context arguments.
  • Added a check in the ExecuteAsync method to return a status code of 0 if the version flag (--version or -v) is present in the command context arguments.

This resolves #560

@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Dec 12, 2024
@christianhelle christianhelle self-assigned this Dec 12, 2024
Copy link

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (326a9e9) to head (9235bd8).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   94.84%   98.92%   +4.08%     
==========================================
  Files          52       52              
  Lines        2578     2513      -65     
==========================================
+ Hits         2445     2486      +41     
+ Misses         98        4      -94     
+ Partials       35       23      -12     
Flag Coverage Δ
unittests 98.92% <ø> (+4.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit ce01537 into main Dec 12, 2024
10 checks passed
@christianhelle christianhelle deleted the version branch December 12, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refitter -v not showing version number
1 participant