Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update dependency fluentassertions to v8" #588

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

christianhelle
Copy link
Owner

@christianhelle christianhelle commented Jan 15, 2025

Reverts #586

FluentAssertions became a paid library starting from version 8.0 and is no longer open source

For more details: fluentassertions/fluentassertions#2943

@christianhelle christianhelle added the dependencies Pull requests that update a dependency file label Jan 15, 2025
@christianhelle christianhelle self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (217a927) to head (a77ef1b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          53       53           
  Lines        2612     2612           
=======================================
  Hits         2479     2479           
  Misses         98       98           
  Partials       35       35           
Flag Coverage Δ
unittests 94.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit 361889e into main Jan 15, 2025
9 checks passed
@jcfnomada
Copy link

Consider using https://github.com/AwesomeAssertions/AwesomeAssertions without having to change source code.

@christianhelle
Copy link
Owner Author

Consider using https://github.com/AwesomeAssertions/AwesomeAssertions without having to change source code.

@jcfnomada Thanks for the tip. AwesomeAssertions provides some Renovate configuration that I should be able to directly use to replace FluentAssertions with AwesomeAssertions

{
  "packageRules": [
    {
      "matchPackageNames": ["FluentAssertions"],
      "replacementName": "AwesomeAssertions",
      "replacementVersion": "7.0.0"
    }
  ]
}

That said, AwesomeAssertions has nothing new and the author writes the following in the README

Please do not expect updates to this fork, as I cannot commit to maintaining it in the future. I will do my best to review and merge critical PRs if required and to release new versions of AwesomeAssertions as needed.

I'll try it out, or maybe I'll stay on FluentAssertions v7.x since there are still commitments to support it with Hotfixes.

I have also been toying with the idea of switching to Shoudly, but I don't see much gain in that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants