Tests: Verify some basic SDO record and array assumptions #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the EDS test accordingly, since the record length only counts sub-objects that have an actual description.
Switch from CompactSubObj to actual sub-entries. Leave out some of the sub-entries, targeting specific SDO tests.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 71.00% 71.16% +0.16%
==========================================
Files 26 26
Lines 3114 3114
Branches 527 527
==========================================
+ Hits 2211 2216 +5
+ Misses 771 766 -5
Partials 132 132 |
|
Notice how 5cbb00e still passes the tests. |
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #538, this will show where the current
SdoRecordlength / iteration behavior is inconsistent. Some other tests related toSdoArraylength and iteration added as well, for symmetry.