GitCommit.raw_log only drop last msg line if blank #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scottnonnenberg, thanks a lot for fixing this! Do you think we could also add a test that ensures one-line commit messages aren't being dropped in the future? |
| length -= 1; | ||
| } | ||
|
|
||
| for(var i = 0; i < length; i++) { | ||
| output = output + ' ' + lines[i] + '\n'; |
There was a problem hiding this comment.
Nit: Please use output += here.
|
Unit tests added. Seems that the couple full repos under /test all have the expected trailing newline, so I couldn't use any existing fixture data. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the message-dropping behavior I saw, potentially the same thing as #38.