Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for uid #13

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[FEATURE] Add support for uid #13

merged 1 commit into from
Apr 4, 2022

Conversation

sypets
Copy link
Contributor

@sypets sypets commented Apr 3, 2022

Previously, it was only possible to filter for table fields, if
they were defined in the TCA. However, it may be useful to be
able to filter by uid or other fields (which do not need a TCA
configuration).

This patch makes it possible to filter by

  • uid (if the field uid exists in the table)
  • and other fields (which exists in the table) for admins only

It was considered to add more support for other fields. This might
be made possible in the future by making the ALLOWED_FIELDS
configurable.

Resolves: #11

Previously, it was only possible to filter for table fields, if
they were defined in the TCA. However, it may be useful to be
able to filter by uid or other fields (which do not need a TCA
configuration).

This patch makes it possible to filter by

- uid (if the field uid exists in the table)
- and other fields (which exists in the table) for admins only

It was considered to add more support for other fields. This might
be made possible in the future by making the ALLOWED_FIELDS
configurable.

Resolves: #11
@sypets
Copy link
Contributor Author

sypets commented Apr 3, 2022

Additionally, I added a return in the loop if self::$filterErrorneous is true, as it is not necessary to check further.

@christophlehmann christophlehmann merged commit 031e503 into christophlehmann:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to filter for fields having no columns configuration in TCA
2 participants