Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go install instructions #32

Closed
wants to merge 1 commit into from

Conversation

damienstanton
Copy link

Using a modern version of Go (1.15.2 in my testing), the instructions are simplified to the point where I would not call it "harder". GOPATH and GOBIN are no longer required, and GO111MODULE is auto by default. Further, you don't need to separately install bitcomplete, and the installation steps aren't different for Windows anymore.

This patch fixes up the installation instructions to represent a modern Go environment.

Using a modern version of Go (1.15.2 in my testing), the instructions are simplified to the point where I would not call it "harder". `GOPATH` and `GOBIN` are no longer required, and `GO111MODULE` is `auto` by default. Further, you don't need to separately install bitcomplete, and the installation steps aren't different for Windows anymore.

This patch fixes up the installation instructions to represent a modern Go environment.
@chriswalz
Copy link
Owner

I'm not sure what you mean by "Further, you don't need to separately install bitcomplete" are you saying Go Get will install both binaries? I'm not sure this is the case.

I checked on my Ubuntu box and my Go 1.15 didn't have a GO111MODULE set to anything so I'm not convinced it' will be consistent across machines. Regardless, I like the idea but I think this needs further investigation

@damienstanton
Copy link
Author

Thanks for the reply! My understanding from the tracking issue for full GOPATH deprecation was that the GO111MODULE env var itself should have been deprecated at Go 1.13 (but I might be misreading the thread and history there).

w.r.t the extra binary, I'll try on my Ubuntu box as well to see if I get consistent results. I noticed on my macOS machine that I only ran the single go get command, as in the Windows install instructions and everything worked fine. So what I meant was that it didn't seem clear why the source install mentioned the need to install bitcomplete separately for macOS/Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants