Add support for TCP interleaved clients #42
+138
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just polling how you feel about this PR. After my last commit, looked into TCP support and it seems like adding support for TCP/interleaved clients was reasonably straightforward.
This does depend on an open PR watson/rtsp-stream#7 which filters interleaved packets from the rtsp-stream Decoder. A
TEARDOWN
request would error if the interleaved packets weren't filtered out for the Decoder.The commit which fixes this (watson/rtsp-stream@7971c99) has been around since 2018, I just kicked off the PR to see if @watson merges it.
I have created a forked version 1.0.1 which incorporates that commit:
https://www.npmjs.com/package/@slyoldfox/rtsp-stream
This also explain the need for the
overrides
inside the package.json inside this PR.The whole thing has been forked in a
2.1.0-interleaved
version at https://www.npmjs.com/package/@slyoldfox/rtsp-streaming-server?activeTab=versions in case the PRs don't come through.Been testing this for a little while for my project (https://github.com/slyoldfox/c300x-controller) and it seems like interleaving successfully works through a NAT port-forwarding setup for my doorbell.