generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the log_url to stop target_url being ignored.
#26
Merged
chrnorm
merged 1 commit into
chrnorm:master
from
jimCresswell:fix/pass-target_url-to-event
May 21, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: "Validate in PR" | ||
| on: | ||
| pull_request: | ||
| branches: [master] | ||
|
|
||
| jobs: | ||
| deploy: | ||
| name: Create test deployment | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v1 | ||
|
|
||
| - uses: chrnorm/deployment-action@releases/v1 | ||
| name: Create GitHub deployment | ||
| id: deployment | ||
| with: | ||
| token: "${{ github.token }}" | ||
| target_url: http://my-app-url.com | ||
| environment: production | ||
| ref: "${{ github.head_ref }}" | ||
|
|
||
| - name: Update deployment status | ||
| uses: ./ | ||
| with: | ||
| token: "${{ github.token }}" | ||
| target_url: http://my-app-url.com | ||
| state: "success" | ||
| deployment_id: ${{ steps.deployment.outputs.deployment_id }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we may as well rename
target_urltolog_url, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tony. I think the fundamental problem is that I want a URL for a deployed app, which should live in
environment_url, but that field isn't included indeployment_statusevents in Github (at least not in a way that is visible inside Github workflows).log_urlshould replacetarget_urlas in @ypresto's PR, but doing so means the data intarget_urlisn't passed to thedeployment_statusevent. So honestly I don't think my PR should go in, the real fix is probably to find out whyenvironment_urlisn't being passed around, and fix it or propose a change, and in the meantime it's necessary to hack what should be the environment URL into the free-formdescriptionfield.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimCresswell Thanks for the response. I don't fully understand your use case, likely due to my own naiveite of Deployment API at the moment.
So if you do develop a one-size-fits-all case, that would be good (if you have time). If not no problem. We'll also see if @ypresto has anything to say