Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up node version because node v16 will be deprecated #49

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

sho-he
Copy link
Contributor

@sho-he sho-he commented Feb 7, 2024

In Github Actions, Node.js 16 will be deprecated.
Please update to use Node.js 20.

Thanks.

refs: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@sho-he sho-he changed the title Bump ip node version because node v16 will be deprecated Bump up node version because node v16 will be deprecated Feb 7, 2024
@sho-he
Copy link
Contributor Author

sho-he commented Feb 7, 2024

issue: #48

@sho-he
Copy link
Contributor Author

sho-he commented Feb 9, 2024

@chrnorm
Could you please check this PR?
Best Regards!

@masspaz
Copy link

masspaz commented Feb 16, 2024

@chrnorm is there a way to push this forward? We got a block in our dev envs.

Copy link

@masspaz masspaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail eventually being in version 2.

Can you update it to actions/checkout@v4?

.github/workflows/check-dist.yml Outdated Show resolved Hide resolved
@sho-he sho-he requested a review from masspaz February 17, 2024 12:10
@mataspetrikas
Copy link

hey @masspaz @chrnorm - could you pls check if is ok to merge and update the release? thank you!

@masspaz
Copy link

masspaz commented Feb 26, 2024

@mataspetrikas wondering if we can merge this in?

@chrnorm chrnorm merged commit 9a72af4 into chrnorm:main Feb 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants