[ENH] JS admin client should throw well-formatted errors rather than Responses #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
codetheweb
changed the title
codetheweb
force-pushed
the
fix-admin-client-errors
branch
from
6e099b1
to
4be42b7
Compare
HammadB
reviewed
May 2, 2024
| @@ -64,7 +65,7 @@ export class AdminClient { | |||
| basePath: path, | |||
| }); | |||
|
|
|||
| this.api = new DefaultApi(apiConfig); | |||
| this.api = new DefaultApi(apiConfig, undefined, chromaFetch); | |||
There was a problem hiding this comment.
for my understanding, why does this result in well formatted errors?
There was a problem hiding this comment.
chromaFetch is a wrapper around fetch() that will throw Errors based on the response status code
by default, the autogenerated client seems to throw Responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the admin client was throwing
Responses rather than Errors. It now uses the same helper as the data plane client to throw well-formatted errors.