[TYP] Rewrite mypy precommit hook

.github/workflows/pr.yml

@@ -99,3 +99,6 @@ jobs:
           pre-commit run --all-files flake8
           pre-commit run --all-files prettier
           pre-commit run --all-files check-yaml
+
+          # mypy issues fixes are in progress so, for now, ignore errors
+          pre-commit run --all-files mypy || true

.gitignore

@@ -24,7 +24,7 @@ server.htpasswd
 server.authz
 server.authn
 
-.venv
+.venv*
 venv
 .env
 .chroma

.pre-commit-config.yaml

@@ -31,30 +31,23 @@ repos:
           - "--extend-ignore=E203,E501,E503"
           - "--max-line-length=88"
 
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: "v1.2.0"
+  - repo: local
     hooks:
       - id: mypy
-        args:
-          [
-            --strict,
-            --ignore-missing-imports,
-            --follow-imports=silent,
-            --disable-error-code=type-abstract,
-            --config-file=./pyproject.toml,
-          ]
-        additional_dependencies:
-          [
-            "types-requests",
-            "pydantic",
-            "overrides",
-            "hypothesis",
-            "pytest",
-            "pypika",
-            "numpy",
-            "types-protobuf",
-            "kubernetes",
-          ]
+        name: mypy
+        entry: "./bin/run-mypy.sh"
+        language: python
+        stages: [manual] # run manually for all issues are fixed
+        pass_filenames: false
+        # use your preferred Python version
+        language_version: python3.12
+        # trigger for commits changing Python files
+        types_or: [python, toml]
+        # use require_serial so that script
+        # is only called once per commit
+        require_serial: true
+        # print the number of files as a sanity-check
+        verbose: true
 
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: "v3.1.0"

bin/run-mypy.sh

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+set -e
+
+pip install -r requirements.txt -r requirements_dev.txt --no-input --quiet
+
+mypy .

pyproject.toml

@@ -55,6 +55,11 @@ pythonpath = ["."]
 
 [tool.mypy]
 ignore_errors = false
+disable_error_code = "type-abstract"
+ignore_missing_imports = false
+strict = false # disable strict mypy checks until we can fix all the errors
+exclude = "bin/.*"
+plugins = "numpy.typing.mypy_plugin"
 
 [[tool.mypy.overrides]]
 module = ["chromadb.proto.*"]

requirements_dev.txt

@@ -4,10 +4,12 @@ grpcio-tools
 httpx
 hypothesis<=6.98.9 # > Than this version has API changes we don't currently support
 hypothesis[numpy]<=6.98.9
+mypy==1.10.0
 mypy-protobuf
 pre-commit
 pytest
 pytest-asyncio
 setuptools_scm
 types-protobuf
+types-PyYAML
 types-requests==2.30.0.0