[BUG]: fix missing record in query result when many records were deleted and pending persist #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted and pending persist Resolves issues like https://github.com/chroma-core/chroma/actions/runs/9952798975/job/27494936402 and https://github.com/chroma-core/chroma/actions/runs/9948297218/job/27482628460. This bug has existed for a while, but was only discovered recently in our property tests because the `max_batch_size` and `max_sync_threshold` parameters were turned down to 10 in `chromadb/test/property/test_persist.py`.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
commented
Jul 17, 2024
| x | ||
| for x in curr_hnsw_result | ||
| if not self._curr_batch.is_deleted(x["id"]) | ||
| ] |
There was a problem hiding this comment.
after reasoning through it for a while I think this fix is the correct approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues like https://github.com/chroma-core/chroma/actions/runs/9952798975/job/27494936402 and https://github.com/chroma-core/chroma/actions/runs/9948297218/job/27482628460.
This bug has existed for a while, but was only discovered recently in our property tests because the
max_batch_sizeandmax_sync_thresholdparameters were turned down to 10 inchromadb/test/property/test_persist.py.