Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] prefetch APIs for Record segment and blockfile #2547

Merged
merged 4 commits into from
Aug 1, 2024
Merged

[ENH] prefetch APIs for Record segment and blockfile #2547

merged 4 commits into from
Aug 1, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jul 19, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Implement prefetch() API at the blockfile level for a set of blocks and use it to prefetch record segment indexes

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Jul 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

@sanketkedia sanketkedia changed the title record segment and blockfile apis [ENH] Record Segment and Blockfile APIs for create Jul 19, 2024
@sanketkedia sanketkedia changed the title [ENH] Record Segment and Blockfile APIs for create [ENH] Implement bulk block fetching and prefetching for improved performance Jul 21, 2024
@sanketkedia sanketkedia changed the title [ENH] Implement bulk block fetching and prefetching for improved performance [ENH] prefetch() APIs for Record segment and blockfile Jul 21, 2024
@sanketkedia sanketkedia marked this pull request as ready for review July 21, 2024 19:45
@sanketkedia sanketkedia changed the title [ENH] prefetch() APIs for Record segment and blockfile [ENH] prefetch APIs for Record segment and blockfile Jul 21, 2024
@sanketkedia sanketkedia mentioned this pull request Jul 21, 2024
Closed
1 task
@sanketkedia sanketkedia force-pushed the 07-19-record_segment_and_blockfile_apis branch from 9fc1ffa to 2b42032 Compare July 22, 2024 20:28
@sanketkedia sanketkedia requested review from HammadB and Ishiihara July 22, 2024 20:30
@sanketkedia sanketkedia mentioned this pull request Jul 23, 2024
Merged
1 task
@sanketkedia sanketkedia force-pushed the 07-19-record_segment_and_blockfile_apis branch 3 times, most recently from bc08c5e to bb57aa3 Compare July 30, 2024 13:46
@sanketkedia sanketkedia mentioned this pull request Jul 31, 2024
Merged
1 task
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Aug 1, 2024 •
edited
Loading

Merge activity

@sanketkedia sanketkedia merged commit 1770d85 into main Aug 1, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanketkedia @HammadB @Ishiihara