Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH][wal3] Manifest snapshotting. #3046

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[ENH][wal3] Manifest snapshotting. #3046

merged 3 commits into from
Dec 10, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Oct 31, 2024

As documented in the README.md, this adds snapshot functionality to bound the size of each manifest write.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from Sicheng-Pan October 31, 2024 23:48
@rescrv rescrv changed the title [ENH] Manifest snapshotting. [ENH][wal3] Manifest snapshotting. Nov 1, 2024
@rescrv rescrv force-pushed the rescrv/wal3-set-prev-next-path branch 2 times, most recently from 3cf9788 to 8f5b20a Compare November 16, 2024 00:10
@rescrv rescrv force-pushed the rescrv/wal3-snapshot-manifest branch from ee88b3a to 2a0a187 Compare November 16, 2024 00:13
@rescrv rescrv force-pushed the rescrv/wal3-set-prev-next-path branch from 8f5b20a to 8a9e0ad Compare November 19, 2024 17:45
@rescrv rescrv force-pushed the rescrv/wal3-snapshot-manifest branch from 2a0a187 to eb7498c Compare November 19, 2024 17:46
@rescrv rescrv force-pushed the rescrv/wal3-set-prev-next-path branch from 8a9e0ad to 9bdee69 Compare November 20, 2024 18:21
@rescrv
[ENH] One-level manifest rollup.
a143c18 
This is one-level manifest rollup, with a design for two-level manifest
rollup.
@rescrv
[ENH] Two-level manifest snapshot.
52f9533
@rescrv rescrv force-pushed the rescrv/wal3-snapshot-manifest branch from eb7498c to 52f9533 Compare November 20, 2024 18:22
Sicheng-Pan
Sicheng-Pan approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rescrv
[BUG] Fix a bug in wal3 manifest snapshots. (#3141)
060a77b 
Low volume writers would hang indefinitely, permanently.

Details in the comments above the change.
@rescrv rescrv merged commit ae795ba into rescrv/wal3-set-prev-next-path Dec 10, 2024
2 of 3 checks passed
@rescrv rescrv deleted the rescrv/wal3-snapshot-manifest branch December 10, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sicheng-Pan Sicheng-Pan Sicheng-Pan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rescrv @Sicheng-Pan