Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local.py #3052

Closed

Conversation

akri2021
Copy link

@akri2021 akri2021 commented Nov 1, 2024

There seems to be a trivial bug with a wrong comment sign from another programming language. I stumbled upon it when testing nano-graphrag with Kotaemon (https://github.com/Cinnamon/kotaemon). After fixing it locally, it worked again.

Other mentions of this bug:
Cinnamon/kotaemon#440
#931

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Change "//" to "#"

There seems to be a trivial bug with a wrong comment sign from another programming language. 
I stumbled upon it when testing nano-graphrag with Kotaemon (https://github.com/Cinnamon/kotaemon)
Other mentions of this bug:
Cinnamon/kotaemon#440
chroma-core#931
Copy link

github-actions bot commented Nov 1, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator

HammadB commented Nov 1, 2024

This change is not correct. // is "integer division" in python. To future readers do not comment these lines out - it is a misunderstanding of python syntax.

The solution for the error you may see is documented on the linked threads.

#931 (comment)
#931 (comment)

zylon-ai/private-gpt#1012 (comment)
zylon-ai/private-gpt#1012 (comment)

@HammadB
Copy link
Collaborator

HammadB commented Nov 1, 2024

Closing due to being incorrect.

@HammadB HammadB closed this Nov 1, 2024
@akri2021 akri2021 deleted the bugfix/replace_wrong_comment_sign branch November 4, 2024 07:38
@akri2021
Copy link
Author

akri2021 commented Nov 4, 2024

Thank you and sorry for the noise! I will mention that solution somewhere in the other project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants