Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Throw InvalidArgumentError instead of ValueError and TypeError #3187

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

aaravnavani
Copy link

@aaravnavani aaravnavani commented Nov 25, 2024

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@aaravnavani aaravnavani marked this pull request as draft November 25, 2024 01:59
@aaravnavani aaravnavani changed the title Throw InvalidArgumentError instead of ValueError and TypeErrro Throw InvalidArgumentError instead of ValueError and TypeError Nov 25, 2024
@aaravnavani aaravnavani marked this pull request as ready for review November 25, 2024 09:59
@aaravnavani aaravnavani changed the title Throw InvalidArgumentError instead of ValueError and TypeError [ENH] Throw InvalidArgumentError instead of ValueError and TypeError Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ValueError/TypeError with InvalidArgumentError
1 participant