[ENH] chroma-load can save and restore running workloads to survive restarts. #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
approved these changes
Dec 10, 2024
rust/load/src/lib.rs
Outdated
Comment on lines
570
to
603
| /* | ||
| /// A workload is a description of a set of operations to perform against a data set. | ||
| #[derive(Clone, Debug, Eq, PartialEq, serde::Deserialize, serde::Serialize)] | ||
| pub enum Workload { | ||
| /// No Operatioon; do nothing. | ||
| #[serde(rename = "nop")] | ||
| Nop, | ||
| /// Resolve the workload by name. | ||
| #[serde(rename = "by_name")] | ||
| ByName(String), | ||
| /// Get documents from the data set according to the query. | ||
| #[serde(rename = "get")] | ||
| Get(GetQuery), | ||
| /// Query documents from the data set according to the query. | ||
| #[serde(rename = "query")] | ||
| Query(QueryQuery), | ||
| /// A hybrid workload is a blend of other workloads. The blend is specified as a list of other | ||
| /// valid workload. The probabilities are normalized to 1.0 before selection. | ||
| #[serde(rename = "hybrid")] | ||
| Hybrid(Vec<(f64, Workload)>), | ||
| /// Delay the workload until after the specified time. | ||
| #[serde(rename = "delay")] | ||
| Delay { | ||
| after: chrono::DateTime<chrono::FixedOffset>, | ||
| wrap: Box<Workload>, | ||
| }, | ||
| /// Load the data set. Will repeatedly load until the time expires. | ||
| #[serde(rename = "load")] | ||
| Load, | ||
| /// Randomly upsert a document. | ||
| #[serde(rename = "random")] | ||
| RandomUpsert(KeySelector), | ||
| } | ||
| */ |
There was a problem hiding this comment.
should this be removed?
rust/load/src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Set the persistent path. | ||
| pub fn set_persistent_path(&mut self, persistent_path: Option<String>) -> Result<(), Error> { |
There was a problem hiding this comment.
I'm a little confused by this method name given it actually loads the persisted state; should LoadService::new() take the persistent_path as a parameter instead?
There was a problem hiding this comment.
I didn't make it a parameter because it failing to load should not fail the creation of the struct. I put it as a fallible method instead so that the error can be logged as a warning and the config dropped.
rescrv
force-pushed
the
rescrv/persist-chroma-load
branch
from
53f8ac8 to
a0ed1e9
Compare
…estarts. Serialize the running workloads to a JSON blob when the configuration option `persistent_state_path` is set to a non-None value.
rescrv
force-pushed
the
rescrv/persist-chroma-load
branch
from
4a84fa6 to
d8f0ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize the running workloads to a JSON blob when the configuration
option
persistent_state_pathis set to a non-None value.