Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Support delayed workloads in chroma-load-start. #3318

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 16, 2024

No description provided.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from Sicheng-Pan December 16, 2024 23:08
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'm wondering if it's worth it to add an auxiliary argument so that the delay can be calculated based on a offset to current time (instead of directly specifying the start timestamp like this)

@rescrv
Copy link
Contributor Author

rescrv commented Dec 16, 2024

Like's done in the humanize_expires time? https://github.com/chroma-core/chroma/blob/main/rust/load/src/lib.rs#L1428

Base automatically changed from rescrv/load-niceties to main December 17, 2024 00:23
@Sicheng-Pan
Copy link
Contributor

Like's done in the humanize_expires time? https://github.com/chroma-core/chroma/blob/main/rust/load/src/lib.rs#L1428

That would be good

@rescrv rescrv merged commit 53ceec3 into main Dec 17, 2024
71 checks passed
@rescrv rescrv deleted the rescrv/load-delay branch December 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants