Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] Deprecate blockfile get_at_index() #3332

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 19, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Deprecate blockfile get_at_index method
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

Sicheng-Pan commented Dec 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 19, 2024 00:03
@Sicheng-Pan Sicheng-Pan force-pushed the 12-18-_cln_deprecate_blockfile_get_at_index_ branch from 789e9dc to 887f467 Compare December 20, 2024 18:06
Copy link
Contributor Author

Sicheng-Pan commented Dec 20, 2024

Merge activity

  • Dec 20, 1:45 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 20, 1:49 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 20, 1:50 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-18-_enh_implement_rank_for_blockfile to graphite-base/3332 December 20, 2024 18:45
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3332 to main December 20, 2024 18:47
@Sicheng-Pan Sicheng-Pan force-pushed the 12-18-_cln_deprecate_blockfile_get_at_index_ branch from 887f467 to ade6563 Compare December 20, 2024 18:48
@Sicheng-Pan Sicheng-Pan merged commit 7bf057a into main Dec 20, 2024
75 of 76 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 12-18-_cln_deprecate_blockfile_get_at_index_ branch February 11, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants