Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add NAC to the write path #3341

Merged
merged 4 commits into from
Dec 20, 2024
Merged

[ENH] Add NAC to the write path #3341

merged 4 commits into from
Dec 20, 2024
+211 −58

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Dec 19, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds NAC to the write path. The NAC rate limits the number of outstanding writes.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia changed the title Add NAC to the write path [ENH] Add NAC to the write path Dec 19, 2024
@github-actions GitHub Actions
Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia marked this pull request as ready for review December 19, 2024 19:25
Sicheng-Pan
Sicheng-Pan approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Dec 20, 2024 •
edited
Loading

Merge activity

  • Dec 20, 5:27 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 20, 5:29 PM EST: A user merged this pull request with Graphite.

@sanketkedia sanketkedia merged commit 4488279 into main Dec 20, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sicheng-Pan Sicheng-Pan Sicheng-Pan approved these changes

@rescrv rescrv rescrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanketkedia @rescrv @Sicheng-Pan