Skip to content

[TST] Seek a bug in log service #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rescrv wants to merge 5 commits into from
Closed

[TST] Seek a bug in log service #4358

rescrv wants to merge 5 commits into from

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented Apr 23, 2025

  • [BUG] There's a bug in count with the log service:

    • I see write 35247.
    • ScoutLogs returns 35201.
    • Thus, the fetch_log operator fails.

    This PR is for hunting it.

  • normal test preset

  • additional tracing

  • only test_add for count

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

9 similar comments
@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@rescrv rescrv changed the title rescrv/exp [TST] Seek a bug in log service Apr 23, 2025
rescrv added 2 commits April 30, 2025 09:21
@rescrv
[BUG] There's a bug in count with the log service:
4e45926 
- I see write 35247.
- ScoutLogs returns 35201.
- Thus, the fetch_log operator fails.

This PR is for hunting it.

normal test preset

additional tracing

only test_add for count

run double

run single

test_add_large only

comment out more tests

undo

more examples and slow testing

uncomment tests

include snapshots in snapshot pointer calculation

test for bugfix

tracing

empty

tracing to catch a bug

moar tracing
@rescrv
remove spammy log line
6006627
rescrv added 3 commits April 30, 2025 09:52
@rescrv
Remove admission controlled s3 to test a hypothesis:
e30c9b8 
1. thread1 calls get_with_etag
2. thread1's request hits s3 and bounces back, but the
   outstanding_read_request persists because the read isn't effectuated
   in-process
3. thread2 installs a new manifest and tells thread3 about it
4. thread3 calls get_with_etag
5. thread3 sees manifest from the past because it piggy-backs on 2.
@rescrv
Revert "Remove admission controlled s3 to test a hypothesis:"
649c4ec 
This reverts commit e30c9b8.
@rescrv
Do not share data on get path
5cebdd8
@rescrv
Copy link
Contributor Author

rescrv commented May 1, 2025

Found in previous PRs (#4416 for forking, #4411 for boundary conditions, #4407 for strongly consistent ops).

@rescrv rescrv closed this May 1, 2025
@rescrv rescrv deleted the rescrv/exp branch May 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rescrv