Skip to content

Conversation

@jairad26
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link
Contributor Author

jairad26 commented Apr 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 jairad26 force-pushed the jai/python-close-clients branch 6 times, most recently from 9bb7a36 to 4a5a9fd Compare April 24, 2025 18:00
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from 4a5a9fd to f8c9080 Compare April 24, 2025 18:09
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from f8c9080 to eb22d18 Compare April 24, 2025 18:16
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from eb22d18 to 64f4c8c Compare April 24, 2025 18:27
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from 64f4c8c to 07ba307 Compare April 24, 2025 18:59
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from 07ba307 to caa4f3d Compare April 24, 2025 22:11
@jairad26 jairad26 force-pushed the jai/type-safety branch 2 times, most recently from 31d1739 to 4f45ca3 Compare April 25, 2025 17:22
@jairad26 jairad26 force-pushed the jai/python-close-clients branch 2 times, most recently from 0d4422a to d438e26 Compare April 25, 2025 17:33
@jairad26 jairad26 force-pushed the jai/type-safety branch 2 times, most recently from 58fd029 to 002b2d6 Compare April 25, 2025 23:41
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from d438e26 to c14ea0c Compare April 25, 2025 23:41
@jairad26 jairad26 changed the base branch from jai/type-safety to graphite-base/4367 April 26, 2025 00:02
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from c14ea0c to e8abc43 Compare April 26, 2025 00:02
@jairad26 jairad26 changed the base branch from graphite-base/4367 to main April 26, 2025 00:02
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from e8abc43 to b2e2ba2 Compare April 29, 2025 17:39
@jairad26 jairad26 force-pushed the jai/python-close-clients branch from b2e2ba2 to f6c1935 Compare April 29, 2025 17:47
@jairad26 jairad26 closed this Jul 1, 2025
@nanae772
Copy link

Hi @jairad26, thanks for your work on this PR.
I noticed it was closed without merging or comments, and I was wondering if there was a specific reason (e.g. replaced by another PR, technical issue, or change in direction).
Understanding this would help me and others know how to contribute in the future. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants