Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic typings for typescript #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lordnox
Copy link

@lordnox lordnox commented Nov 21, 2017

These are just the basics to have typescript not complain about missing untyped module.

I sadly don't have enough time to finish the types correctly, may be I'll find time later in the week.

See: #41

Thank you for this module!

@codecov-io
Copy link

codecov-io commented Nov 21, 2017

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines          65     65           
  Branches       13     13           
=====================================
  Hits           65     65
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d6bd7...fd6e927. Read the comment docs.

@ericwooley
Copy link

So... I guess this didn't quite make the merge?

@osdiab osdiab mentioned this pull request Apr 24, 2020
@saiichihashimoto
Copy link

@lordnox, are you able to move this into https://github.com/DefinitelyTyped/DefinitelyTyped? Development on this repo seems dead but usage is pretty high, so that seems like the only way to accomplish this.

@lordnox
Copy link
Author

lordnox commented Dec 21, 2020

@saiichihashimoto I am actually not using this anymore either.

If there is interest you could move it yourself, however I think I would be best if someone takes over this project, maybe a fork, I'd push this change to the new repository then.

@saiichihashimoto
Copy link

I see. I don't really have time to get into this (especially with the high barrier to entry for DefinitelyTyped changes), so I'll leave this for someone else.

@saiichihashimoto
Copy link

One more appeal to @chromakode before abandoning this.

@chromakode
Copy link
Owner

Hi @saiichihashimoto and @lordnox. Sorry for the slow response on this -- I don't currently have bandwidth to maintain this library. In my opinion, these typings are not complete enough to merit inclusion, due to the use of the any type. I would want to see a complete translation of the PropTypes in each component (example) into TypeScript typings.

That being said, there are other reasons why I think that starting a project with react-html-email in 2021 would be inadvisable -- such as use of PropTypes, the reliance on module global configuration, and the lack of extensibility when compared to modern component libraries based on emotion and styled-components. Modernizing this codebase would not be a ton of work, but it is not a priority for me right now. I have updated this repo to note that it is no longer maintained. If you're interested in taking that on, I'd be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants