Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching GitHub Actions to uv #147

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

ebezzam
Copy link
Contributor

@ebezzam ebezzam commented Jan 6, 2025

As the title says, the GitHub Actions have been updated to use uv, according to their recommendations.

Other changes:

  • the linting workflow wasn't actually outputting an error if files weren't properly linted. I've added the --check flag to do this, and used ruff to reformat files locally (hence the many files changes)
  • a few notebooks needed manual changes due to an ambiguous variable name (i.e. l)
  • updated installation docs on how to install with uv

Copy link
Collaborator

@GJBoth GJBoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thank you very much! Everything looks good, except I don't see the uv version pinned in the action? That would be the only change I'd like to see.

@ebezzam
Copy link
Contributor Author

ebezzam commented Jan 9, 2025

@GJBoth I've set the uv version in both workflows

@GJBoth GJBoth merged commit 0047405 into chromatix-team:main Jan 10, 2025
1 check passed
@ebezzam
Copy link
Contributor Author

ebezzam commented Jan 10, 2025

@GJBoth thanks for merging. I saw that ruff failed on the main branch 🤔 I'm looking into it

@ebezzam
Copy link
Contributor Author

ebezzam commented Jan 10, 2025

Looks ruff just released yesterday a new version (0.9.0) with a breaking change which is what the GitHub Action on the main branch installed: https://github.com/chromatix-team/chromatix/actions/runs/12711344838/job/35434459952#step:5:48

While the one in my fork used 0.8.6: https://github.com/ebezzam/chromatix/actions/runs/12688474060/job/35365083147#step:5:48

Should we do a new commit to reformat with 0.9.0 or limit the version of ruff?

@diptodip
Copy link
Collaborator

Thanks @ebezzam!

@GJBoth
Copy link
Collaborator

GJBoth commented Jan 10, 2025

@ebezzam Well that's bad luck if I ever saw it...
Since we're changing to uv anyway, let's go for 0.9.0? What do you think?

@ebezzam
Copy link
Contributor Author

ebezzam commented Jan 10, 2025

I agree. I'll make a new PR for that, and add some info on setting up pre-commit hooks so that formatting is better integrated in the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants