-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SidebarBottom to toggle sidebar filtering based on story status #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Question regarding the new fixed version of storybook, and whether this should wait until that's stable to be merged
@ghengeveld I approved from the look of the code, however testing this I couldn't actually see the filter menu in storybook. Is there anything extra you need to do to enable or, or should switching to this branch, running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but we should work out what we are doing with errors. I'm OK with creating a ticket for that and merging as is though.
Fixes AP-3301, AP-3302, AP-3303
Also removes the "pending" story status, because it shows as an ugly "clock" icon and we don't really need to show the "in progress" state of a test in the sidebar.
Note: this depends on a canary version of Storybook and I had to downgrade to React 16 for Storybook compatibility.
📦 Published PR as canary version:
0.0.40--canary.45.460fa88.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0 # or yarn add @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0