-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --stats-json flag for SB 8.0.0+ #1049
Use --stats-json flag for SB 8.0.0+ #1049
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's rather unfortunate. This fix makes sense though!
🚀 PR was released in |
This PR introduced Turbosnap to stop working; I was getting the following error message:
Consider updating the error message here:
to
Passing pass |
@Densitibo, sorry for the broken build! What version of Storybook are you running? I'm curious if we have an edge case somewhere that it would go down the wrong path and use the new flag when it is not actually supported. |
I'm running |
At 8.0.0, --webpack-stats-json was renamed to --stats-json
Prefer that option for projects using 8.0.0 or greater.
New version of #1035, which had a bug when
storybook.version
was missing on theContext
object.📦 Published PR as canary version:
11.10.3--canary.1049.10997678109.0
✨ Test out this PR locally via:
npm install chromatic@11.10.3--canary.1049.10997678109.0 # or yarn add chromatic@11.10.3--canary.1049.10997678109.0