Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable eslint-plugin-jsdoc ESLint rule #1066

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 30, 2024

Simply adds the eslint-plugin-jsdoc plugin and enables our ESLint rules then it fixes any errors that appeared.

I also made a couple changes as part of this:

  1. Deleted node-src/lib/getStorybookConfiguration.ts because it's not being used outside of some tests 🤷‍♂️
  2. Deleted the references to LOGGLY_CUSTOMER_TOKEN that is no longer used
📦 Published PR as canary version: 11.11.1--canary.1066.11115073541.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1066.11115073541.0
# or 
yarn add chromatic@11.11.1--canary.1066.11115073541.0

@codykaup codykaup added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Sep 30, 2024
@codykaup codykaup self-assigned this Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

📦 Package Size: 4160 KB
✅ Compared to main: 0 KB 83a81fe (4160 KB)

@codykaup codykaup force-pushed the cody/cap-2200-eslint-add-jsdoc-config branch from c713059 to ca61231 Compare September 30, 2024 20:13
Copy link

codacy-production bot commented Sep 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.31% (target: -1.00%) 32.69% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (83a81fe) 8407 4543 54.04%
Head commit (a221eb9) 8399 (-8) 4513 (-30) 53.73% (-0.31%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1066) 52 17 32.69%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 30, 2024 20:19
@codykaup codykaup force-pushed the cody/cap-2200-eslint-add-jsdoc-config branch from ca61231 to a221eb9 Compare September 30, 2024 22:18
@codykaup codykaup added patch Auto: Increment the patch version when merged and removed minor Auto: Increment the minor version when merged labels Sep 30, 2024
@codykaup codykaup added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit c97b1b9 Sep 30, 2024
23 of 24 checks passed
@codykaup codykaup deleted the cody/cap-2200-eslint-add-jsdoc-config branch September 30, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants