-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter ANSI escape codes for Sentry #1068
Filter ANSI escape codes for Sentry #1068
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
📦 Package Size: 4640 KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work adding a test to make sure that stripAnsi
does what we expect!
The dev/prod division belongs in `environment`, we will bake the cli/action distinction as `entrypoint`
bad4dd1
to
fb6b601
Compare
Removes ANSI escape codes from error and console log messages before being sent to Sentry.
Additionally, using
environment
for thecli
/action
distinction was incorrect. Move that toentrypoint
and set a build time variable forSENTRY_ENVIRONMENT
to bake it in appropriately.📦 Published PR as canary version:
11.11.1--canary.1068.11147048454.0
✨ Test out this PR locally via:
npm install chromatic@11.11.1--canary.1068.11147048454.0 # or yarn add chromatic@11.11.1--canary.1068.11147048454.0