-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining TypeScript errors and unable strict: true
#1072
Fix remaining TypeScript errors and unable strict: true
#1072
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
📦 Package Size: 4644 KB |
e4e0a70
to
b1f68c5
Compare
This is a continuation from #1070 by cleaning up the remaining errors and finally enabling strictness in our
tsconfig.json
! 🎉I tried to make these changes as small as possible to not change the flow but some of the errors made that difficult. In theory, a good chunk of these rely on values existing despite the
Context
type having them as optional so throwing new errors when they don't exist shouldn't do anything in practice.📦 Published PR as canary version:
11.11.1--canary.1072.11163487586.0
✨ Test out this PR locally via:
npm install chromatic@11.11.1--canary.1072.11163487586.0 # or yarn add chromatic@11.11.1--canary.1072.11163487586.0