Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining TypeScript errors and unable strict: true #1072

Merged

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Oct 2, 2024

This is a continuation from #1070 by cleaning up the remaining errors and finally enabling strictness in our tsconfig.json! 🎉

I tried to make these changes as small as possible to not change the flow but some of the errors made that difficult. In theory, a good chunk of these rely on values existing despite the Context type having them as optional so throwing new errors when they don't exist shouldn't do anything in practice.

📦 Published PR as canary version: 11.11.1--canary.1072.11163487586.0

✨ Test out this PR locally via:

npm install chromatic@11.11.1--canary.1072.11163487586.0
# or 
yarn add chromatic@11.11.1--canary.1072.11163487586.0

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Oct 2, 2024
@codykaup codykaup self-assigned this Oct 2, 2024
Copy link

codacy-production bot commented Oct 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.12% (target: -1.00%) 69.12% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c7a3f96) 8501 4580 53.88%
Head commit (b1f68c5) 8606 (+105) 4647 (+67) 54.00% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1072) 217 150 69.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

github-actions bot commented Oct 2, 2024

📦 Package Size: 4644 KB
✅ Compared to main: 0 KB c7a3f96 (4644 KB)

@codykaup codykaup requested a review from a team October 2, 2024 21:54
node-src/lib/getDependentStoryFiles.ts Outdated Show resolved Hide resolved
node-src/lib/getPackageManager.ts Show resolved Hide resolved
@codykaup codykaup force-pushed the cody/cap-2188-add-typescript-config-from-capture-cloud-2 branch from e4e0a70 to b1f68c5 Compare October 3, 2024 14:02
@codykaup codykaup added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 77045b5 Oct 3, 2024
19 of 20 checks passed
@codykaup codykaup deleted the cody/cap-2188-add-typescript-config-from-capture-cloud-2 branch October 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants