-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps for how to run builds against local CLI #1113
Add steps for how to run builds against local CLI #1113
Conversation
π¦ Package Size: 5380 KB |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settingsΒ Β Β Β Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
eaf998e
to
1613b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to mention the node <path/to/dist>
option as well? Or call out the downsides of that method?
Good idea! |
6ba38ad
to
8761bab
Compare
@@ -60,7 +60,7 @@ async function build() { | |||
await $({ | |||
stdout: 'inherit', | |||
stderr: 'inherit', | |||
})`sentry-cli releases set-commits --auto ${nextVersion}`; | |||
})`sentry-cli releases set-commits --auto ${nextVersion} --ignore-missing`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased at some point which broke the sentry-cli
because it couldn't find the commits. Passing --ignore-missing
allows the CLI to fallback to the default behavior if it hits this error. Based on their docs, passing this every time shouldn't have a downside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it!
π PR was released in |
Just as the title says - this adds docs on how to run a separate project against your local copy of the CLI.
π¦ Published PR as canary version:
11.16.5--canary.1113.11667958515.0
β¨ Test out this PR locally via:
npm install chromatic@11.16.5--canary.1113.11667958515.0 # or yarn add chromatic@11.16.5--canary.1113.11667958515.0