-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send project metadata to the index #1122
Send project metadata to the index #1122
Conversation
📦 Package Size: 5448 KB |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
1. Shorter timeouts, but errors will just lead to undefined 2. Don't pipe to `head` or `wc` as they may not exist
15cad05
to
3221fcb
Compare
I think it's a good trade off to add a |
@jmhobbs done! Looks like it still works (2 and 0 are the correct values for the repo I was testing with): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't QA'd, and there's some CI issues, but overall looks right to me.
@jmhobbs FYI the CI issues (outside of Codacy) is due to the production index not yet having |
134bbb3
to
6daedce
Compare
🚀 PR was released in |
Reverts #1121 (re-implements #1112) and incorporates #1120.
Also:
wc
orhead
as they may not be there. Instead:head -n 1
via streamswc
.execGitCommandCountLines
but I figured it was better to keep the complexity down.Things to check in QA:
head
orwc
.📦 Published PR as canary version:
11.21.0--canary.1122.12130166324.0
✨ Test out this PR locally via:
npm install chromatic@11.21.0--canary.1122.12130166324.0 # or yarn add chromatic@11.21.0--canary.1122.12130166324.0