✨ Add properties to XML reporting based on status.

[jwir3]

The status of particular test cases is now reported in the JUnit-formatted XML report. It is given as a <property> child element on the <testcase> element.

Refs CAP-2408.

📦 Published PR as canary version: 11.20.0--canary.1125.12016128389.0

✨ Test out this PR locally via:

npm install chromatic@11.20.0--canary.1125.12016128389.0
# or 
yarn add chromatic@11.20.0--canary.1125.12016128389.0

[github-actions]

📦 Package Size: 5444 KB

[codykaup]

@jwir3 I forget, is this one ready to be reviewed?

[jwir3]

@jwir3 I forget, is this one ready to be reviewed?

Should be ready now. Thanks!

[codykaup]

@jwir3 I forget, is this one ready to be reviewed?

Should be ready now. Thanks!

@jwir3 lint-and-test is still failing 🤔

[jmhobbs]

Lockfile change is huge. Need to re-run yarn maybe?

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 691ad521	✅ 93.33% (target: 80.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (691ad52)	Report Missing	Report Missing	Report Missing
Head commit (06aeb09)	7140	4863	68.11%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1125)	30	28	93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[jwir3]

@jmhobbs I had to checkout yarn.lock from main and then re-commit it after running yarn install. I think it's right now. Something was weird with it, though, because I also added back in TS error comments that I removed. Perhaps the original PR updated the typescript version? I'm not quite sure, but it should be fixed now.

[codykaup]

Works great over here! Just some questions about the refactoring bit!

[codykaup]

Sorry, mean to "comment" instead of "approve" 😬

[jwir3]

Sorry, mean to "comment" instead of "approve" 😬

No worries. I'll re-request review before pushing after I make those changes.

[codykaup]

Looks great, nice work!

[jwir3]

@brockwood Do you happen to know if this might be failing to merge on the merge queues possibly due to a token issue after all the token recycles yesterday?

[codykaup]

@brockwood Do you happen to know if this might be failing to merge on the merge queues possibly due to a token issue after all the token recycles yesterday?

@jwir3 it's failed on a GraphQL query for some reason. 🤔

INTERNAL_SERVER_ERROR: Cannot return null for non-nullable field PullRequest.headRefName.

[codykaup]

@brockwood Do you happen to know if this might be failing to merge on the merge queues possibly due to a token issue after all the token recycles yesterday?

@jwir3 it's failed on a GraphQL query for some reason. 🤔

INTERNAL_SERVER_ERROR: Cannot return null for non-nullable field PullRequest.headRefName.

Pretty sure this is related to me updating the smoke test project. Looking now!

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 691ad521	✅ 93.33% (target: 80.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (691ad52)	Report Missing	Report Missing	Report Missing
Head commit (06aeb09)	7140	4863	68.11%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1125)	30	28	93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[chromatic-ci-bot]

🚀 PR was released in v11.19.0 🚀