Account for configs when checking exitOnceUploaded
in action
#1130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
In our Action, we default
exitOnceUploaded
tofalse
which means any options set in a configuration are ignored. Instead, we can default it toundefined
so things parse out later on (and account for config options).Test runs with this branch:
📦 Published PR as canary version:
11.20.2--canary.1130.12263328287.0
✨ Test out this PR locally via:
npm install chromatic@11.20.2--canary.1130.12263328287.0 # or yarn add chromatic@11.20.2--canary.1130.12263328287.0