-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Storybook React in PT to match the most recently in EN #490
Update the Storybook React in PT to match the most recently in EN #490
Conversation
@elfiservice thank you for the time and effort you put into the pull request. But instead of just one chapter, we'd love to get the Portuguese translations updated to the latest version of the content. If you're willing to work on it, could you please adjust the title of the pull request, and continue working on it and let me know once you're done. One small comment to help you get this merged faster. If you don't mind leave the code's comments in their natural form (English). I know that translating them, brings it closer to home. But just for consistency purposes leave it as is. Let me know. Stay safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions that improve the legiability in portuguese.
Co-authored-by: Kauan Schaeffer <37464395+K-Schaeffer@users.noreply.github.com>
Co-authored-by: Kauan Schaeffer <37464395+K-Schaeffer@users.noreply.github.com>
Co-authored-by: Kauan Schaeffer <37464395+K-Schaeffer@users.noreply.github.com>
tks @K-Schaeffer for the review 🙏🏽 |
@elfiservice if you don't mind updating the Get started section based on #504 we'd appreciate it. I'm going to take a look at it sometime next week and if anything stands out, I'll gladly merge it and release the updated version. Let me know once you've taken care of this and we'll go from there. |
Hi @jonniebigodes , lets update :)
|
@elfiservice what I meant with my previous comment was to include the instructions to set the branch to main in the Get started section. More specifically in "Confirmar as alterações" heading. As a reference see how it's mentioned in the English version. While we're at this, do you have any plans on checking the rest of the translation and update the content and possibly the wording? Let me know and we'll go from there. Stay safe |
@elfiservice Closing this for now as it seems that there's been no movement from your end for quite some time. If you are able to update the Portuguese translation, please feel free to open a new pull request and ping me for a review and we'll take it from there. Looking forward to seeing this translation get the much-deserved updates it requires. Hope you have a great week. Stay safe |
I did some adjusts following the EN (English) that is in production