Skip to content

Commit

Permalink
audio-qv/cros-cop: Disable oss-fuzz check-step
Browse files Browse the repository at this point in the history
It's failing on TOT:
https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/4903456/comments/51651b22_69436f20

BUG=b:303194232
TEST=devtools/copgen.sh

Change-Id: I14d0c48f3d0e0bb1014f13c3ff30dd4b163affc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/4907683
Tested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com <chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com>
Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>
Commit-Queue: Li-Yu Yu <aaronyu@google.com>
  • Loading branch information
afq984 authored and Chromeos LUCI committed Oct 3, 2023
1 parent a2ac7e3 commit ceafa21
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 29 deletions.
15 changes: 0 additions & 15 deletions .cop/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -669,21 +669,6 @@
"oss-fuzz-coverage:0"
],
"entrypoint": "python3"
},
{
"name": "gcr.io/google.com/cloudsdktool/cloud-sdk",
"args": [
"oss-fuzz/infra/helper.py",
"coverage",
"cras",
"--port="
],
"dir": "oss-fuzz-coverage",
"id": "oss-fuzz-coverage:2",
"waitFor": [
"oss-fuzz-coverage:1"
],
"entrypoint": "python3"
}
],
"timeout": "1200s",
Expand Down
37 changes: 23 additions & 14 deletions devtools/quick-verifier/build/build_steps.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,16 @@ func ossFuzzSetupSteps() *buildplan.Sequence {
}

func ossFuzzSteps(id, sanitizer, engine string) *buildplan.Sequence {
var checkStep *buildplan.Step
rsyncStep := buildplan.Command(archlinuxBuilder, "rsync", "-ah", "oss-fuzz-setup/", id+"/")
buildStep := &buildplan.Step{
Name: "gcr.io/cloud-builders/docker",
Entrypoint: "python3",
Args: []string{"oss-fuzz/infra/helper.py", "build_fuzzers", "--sanitizer", sanitizer, "--engine", engine, "cras", "/workspace/" + id + "/adhd"},
Dir: id,
}

if sanitizer == "coverage" {
checkStep = &buildplan.Step{
checkStep := &buildplan.Step{
Name: "gcr.io/google.com/cloudsdktool/cloud-sdk",
Entrypoint: "python3",
Args: []string{
Expand All @@ -196,25 +203,27 @@ func ossFuzzSteps(id, sanitizer, engine string) *buildplan.Sequence {
},
Dir: id,
}
_ = checkStep // Disabled for b/303194232.
return buildplan.Commands(
id,
rsyncStep,
buildStep,
// checkStep, // Disabled for b/303194232.
)
} else {
checkStep = &buildplan.Step{
checkStep := &buildplan.Step{
Name: "gcr.io/cloud-builders/docker",
Entrypoint: "python3",
Args: []string{"oss-fuzz/infra/helper.py", "check_build", "--sanitizer", sanitizer, "--engine", engine, "cras"},
Dir: id,
}
return buildplan.Commands(
id,
rsyncStep,
buildStep,
checkStep,
)
}
return buildplan.Commands(
id,
buildplan.Command(archlinuxBuilder, "rsync", "-ah", "oss-fuzz-setup/", id+"/"),
&buildplan.Step{
Name: "gcr.io/cloud-builders/docker",
Entrypoint: "python3",
Args: []string{"oss-fuzz/infra/helper.py", "build_fuzzers", "--sanitizer", sanitizer, "--engine", engine, "cras", "/workspace/" + id + "/adhd"},
Dir: id,
},
checkStep,
)
}

func copgenCheckSteps() *buildplan.Sequence {
Expand Down

0 comments on commit ceafa21

Please sign in to comment.