-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build/local serving to Vite #150
Comments
Got unblocked on Sass, turns out Squoosh was affecting how Sass gets imported by Vite. Removing Vite Plugin Img made Sass work again! This means that, for #154, Squoosh will need to be removed as a render option from Vite Plugin Img if we wind up using that module. |
Need some of the transforms from #143 complete in order to finish this (otherwise required hooks for JS and CSS may not be there!). Kind of a circular dependency situation; needed the 1st half of this to be done to then start on that to then finish this. |
Compiling of HTML is blocked on vitejs/vite#6113 |
The PR got merged and I've got a patch that we can apply locally to unblock this for now until the PR lands in a stable branch |
Featured paint worklet is a little funky but otherwise it looks like our JS, workers, and service worker work as expected. Filed vite-pwa/vite-plugin-pwa#192 so we don't have to precache all of the HTML |
Upped to a 21 because this actually was more like a mini epic |
With 2a18001 I'm marking this issue closed. The site runs great in both dev and prod builds using the new setup. The service worker still needs work, but we knew that already. Any additional bugs will be filed and worked on independently. |
Our current Rollup/Gulp combination is slow, cumbersome, and less likely to give us the optimized output we'd want than Vite is, which is optimized for code splitting and modern ES module forward builds.
The text was updated successfully, but these errors were encountered: