Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions for linting #143

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update versions for linting #143

merged 1 commit into from
Jan 22, 2025

Conversation

nharper
Copy link
Collaborator

@nharper nharper commented Jan 21, 2025

make lint is currently failing in CI, probably due to an old version of go or staticcheck.

`make lint` is currently failing in CI, probably due to an old version
of go or staticcheck.
@nharper nharper requested a review from carlosjoan91 January 21, 2025 22:56
Copy link
Collaborator

@carlosjoan91 carlosjoan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgarron
Copy link
Collaborator

lgarron commented Jan 21, 2025

We also have some active vuln alerts, might be worth doing a general dep bump? https://github.com/chromium/hstspreload/security/dependabot

@nharper
Copy link
Collaborator Author

nharper commented Jan 22, 2025

Doing a dep bump sounds like a good idea - doing that in #144.

@nharper nharper merged commit 046fceb into chromium:main Jan 22, 2025
2 checks passed
@nharper nharper deleted the ci-update branch January 22, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants