Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA support #75

Open
pwnall opened this issue Aug 17, 2020 · 8 comments
Open

PWA support #75

pwnall opened this issue Aug 17, 2020 · 8 comments

Comments

@pwnall
Copy link

pwnall commented Aug 17, 2020

Would the team be interested in a PR that adds enough support for this site to meet Chrome's PWA installability bar? This would entail an app manifest with icons, and a service worker.

@lgarron
Copy link
Collaborator

lgarron commented Aug 17, 2020

We have an icon at https://github.com/chromium/permission.site/blob/master/app-icon.png that you could use.

If we have a service worker, does that preclude using the site over HTTP? The site needs to be accessible over both HTTP and HTTPS for testing.

@dway123
Copy link

dway123 commented Mar 13, 2021

+1 to PWA support. It'd be great to see these permission UX flows when viewed in PWA windows as well.

Re: HTTP: Would it be possible to have a service worker (and other PWA code) only run when using https?

@lgarron
Copy link
Collaborator

lgarron commented Mar 13, 2021

Re: HTTP: Would it be possible to have a service worker (and other PWA code) only run when using https?

That sounds unlikely, but I'm not sure. Any chance you can try to make a demo?

@dway123
Copy link

dway123 commented Mar 16, 2021

Oops I'm not too sure how to make a demo like this yet either... Sorry.

@LuHuangMSFT
Copy link

+1 to PWA support. There are interesting permissions scenarios to consider when thinking about PWA specific browser features and this tool would really help.

AFAIK, service worker source must be served from a https:// URL. The http:// version of this tool would not be installable. The SW would also not work or not be registrable if served from a relative URL to the http:// origin. It's very likely no differences are necessary between the http:// and https:// sites.

@FluorescentHallucinogen
Copy link
Contributor

I would love to create a pull request. It's easy! 😉

PWA support is important because some powerful Web APIs like WebUSB API in the foreseeable future can be restricted to only installed web apps.

All I need is the app icon in 512x512px resolution. This is one of the PWA criteria.

The icon in the highest resolution we now have is 288x288px (https://github.com/chromium/permission.site/blob/master/app-icon.png).

@lgarron Do you have the original of the icon?

@lgarron
Copy link
Collaborator

lgarron commented Nov 30, 2021

@lgarron Do you have the original of the icon?

Here are my working files, with an export up to 2880px: https://drive.google.com/drive/folders/0B6FmQe6bc6yVYU1uS2l3a2ZETVU?resourcekey=0-JsVOYEKU61l7Khzamdv9XQ&usp=sharing

Here's an optimized 512px version:
logo_512w

(If you're making a PR, please make sure that the presence of the PWA manifest doesn't automatically prevent access to the HTTP version of the site in the major browsers. Thanks for working on this!)

@FluorescentHallucinogen
Copy link
Contributor

Good news! Web push notifications are available for web apps on iOS and iPadOS since version 16.4 beta 1 (official announcement: https://webkit.org/blog/13878/web-push-for-web-apps-on-ios-and-ipados/), but web app must be installed to home screen.

So I prioritize this feature in my backlog. :)

I should also add a note that notifications require PWA installation to work on iOS.

FluorescentHallucinogen added a commit to FluorescentHallucinogen/permission.site that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants