-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise default include/exclude patterns for Chromium enlistements #70
Comments
@randomascii fyi |
It could also be helpful to have an action that takes the defaults and creates a vs-chromium-project.txt file for editing. Right now switching from the defaults to a configuration file is a big change with unclear consequences. |
Remove all exclusion rules for files that can contain text, leaving only exclusion rules for file extensions that are known to be binary files (e.g. .obj, .pdb, .exe, etc.) This increase the number of files scanned and indexed by default, but makes the rules more general purpose and avoid confusions related to seemingly incomplete search results. This fixes issue #70
Note: Before;
After;
That is quite an increase in memory usage (~50%). Most of the increase come from files with these extensions:
|
Fixed in v0.9.37 |
The list of default files to include/exclude for Chromium enlistments was written years ago and has not been updated since then. For example, the search pattern exclude "*.s" files (assembly source files). There is not reason to do that anymore.
The default files are located here:
https://github.com/chromium/vs-chromium/tree/master/src/Server/Configuration
They can be overridden using custom configuration files, but the list should be simplified for more general usage.
The text was updated successfully, but these errors were encountered: