Add concept of installable plugins #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyfen
force-pushed
the
plugins
branch
2 times, most recently
from
c7a3be1 to
ca2b30c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chronicle plugins are packaged as independent gems with a dependency on
chronicle-etl. Two independent plugins can depend on incompatible versions of a third-party dependency (faraday, sqlite3, etc). More on that in #24.We want to minimize dependency conflict by only activating a plugin if it's required by a job. This PR moves towards that goal.
We still need a system for plugins to report available connectors that doesn't require them each gem to be activated/required (#29)