Make TIMEZONES map public, so that users may iterate over all timezones. #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could imagine, that this PR is not implemented in the way you'd prefer. I mostly want to get the conversation started and offer one possible implementation.
For a feature, I thought it would be nice to create an auto-correct dictionary for all known timezones.
So, in this PR I am changing
static TIMEZONES
topub static TIMEZONES
. On the user side, I am simply creating a list off all timezones like this:chrono_tz::TIMEZONES.keys().map(|x| x.to_string()).collect()
.Is this something you would be willing to support? Would you prefer a new function that hid the access to TIMEZONES behind a function?
Pinging previous authors of the modified file: @quodlibetor @petrosagg