Disable wasmbind feature by default #1164
Labels
API-incompatible
Tracking changes that need incompatible API revisions
Comments
|
The problem is that this would be a breaking change for users that rely on the |
pitdicker
added
the
API-incompatible
erickt
added a commit
to erickt/chrono
that referenced
this issue
Feb 29, 2024
This removes `wasmbind` from the default feature set, which stops chrono from implicitly depending upon wasm-bindgen and js-sys. This is helpful for a few reasons: * It reduces the default dependency set by default for non-wasm projects, which shrinks the download size. * Projects like Fuchsia have a policy where 3rd party crates need to be audited. While we don't use wasm-bindgen, we can't opt out of it by setting `default-features = false` because of [feature unification] ends up enabling chrono's default feature. See this [cargo issue] for more details. `wasm-bindgen` is large and complicated, so it's pretty expensive for us to update. Fixes chronotope#1164 [feature unification]: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification [cargo issue]: rust-lang/cargo#4463
djc
pushed a commit
that referenced
this issue
Feb 29, 2024
This removes `wasmbind` from the default feature set, which stops chrono from implicitly depending upon wasm-bindgen and js-sys. This is helpful for a few reasons: * It reduces the default dependency set by default for non-wasm projects, which shrinks the download size. * Projects like Fuchsia have a policy where 3rd party crates need to be audited. While we don't use wasm-bindgen, we can't opt out of it by setting `default-features = false` because of [feature unification] ends up enabling chrono's default feature. See this [cargo issue] for more details. `wasm-bindgen` is large and complicated, so it's pretty expensive for us to update. Fixes #1164 [feature unification]: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification [cargo issue]: rust-lang/cargo#4463
|
#1472 fixes this for 0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When compiling a dependency that transitively includes chrono for a wasm32 target, chrono implicitly pulls in wasm_bindgen. However, this is not desirable if you are not using wasm bindgen, but compiling for a plain wasm target. wasm_bindgen imposes requirements on the output wasm file, e.g. imports it needs from the JS environment, which might not always be available. Assuming that all wasm32-unknown-unknown targets are using wasm_bindgen is not a safe assumption.
If chrono was a direct dependency, I could turn off the default features, but since it is a transitive dependency this is not possible. Therefore I think it should be turned off by default. Turning on features in transitive dependencies is possible via feature unification. You'd make chrono a direct dependency and add the wasmbind feature, and it will also be enabled for other dependencies. However the opposite is not possible.
The text was updated successfully, but these errors were encountered: