-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate panicking TimeDelta
initializers
#1408
Comments
Once replacements are in the field, I think the next release after about 1-2 months should be okay to deprecate. Might be interesting to pick apart the crates.io downloads to figure out what old releases are still getting picked up (and maybe, why)? |
From #1408 (comment):
https://lib.rs/crates/chrono/versions has a nice breakdown. With just a superficial look there is a big correlation between use and for how long a version was the latest release. Top 5:
It seems to me there are no obvious blockers for users to upgrade. At least the 150 most popular crates that use chrono don't specify a max version, only a minimum version of chrono. Also interesting that (2.4 + 0.145 + 2.1 + 0.77) / 6.678 = 71% of our users are now on a version of chrono without the time 0.1 dependency. I have no idea how to figure out which older version of other crates causes the downloads of for example 0.4.19. |
Duration
initializersTimeDelta
initializers
The following methods can panic and have a
try_
variant:The replacement methods have been introduced only recently in 0.4.32, and
Duration::try_milliseconds
has not seen a release yet.In all other places in chrono we have deprecated such panicking methods, and I suppose we should do the same here.
I wonder when would be the right time?
cc @danwilliams
The text was updated successfully, but these errors were encountered: