Inline a handful of functions from num-integer #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is pre-existing. |
jtmoon79
suggested changes
Mar 30, 2023
The motivation for this is that we use a very small portion of what num-integer provides, but it's a relatively heavy dependency -- it brings in several crates with build scripts. The goal here is to reduce compilation time for projects using chrono.
jtmoon79
approved these changes
Mar 30, 2023
|
The module isn't public, so I don't think it'd show up in docs either way? |
Good point! |
|
Oh, good idea. It would be nice to have this on 0.4.x as well, would you mind rebasing? |
|
@djc hmm, So 0.4.x has |
|
#794 is the PR that removed the num-traits usage in the API, FWIW. |
|
Ah yeah, that would be the reason we haven't done this on 0.4. Okay, let's just do this on 0.5? |
|
Sounds good. I think this is ready for review then (modulo the CI issues that are also present on main.) |
djc
approved these changes
Apr 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is that we use a very small portion of what num-integer provides, but it's a relatively heavy dependency -- it brings in several crates with build scripts. The goal here is to reduce compilation time for projects using chrono.
Let me know if you'd prefer I rebase this onto the 0.4.x branch.