-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_type_types
on 32-bit targets
#1235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
+ Coverage 86.10% 86.32% +0.22%
==========================================
Files 37 35 -2
Lines 13522 13896 +374
==========================================
+ Hits 11643 11996 +353
- Misses 1879 1900 +21
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to put a version bump in there?
Do you think this warrants a new release already? (because it is a test, and only behind the |
Semver-compatible releases are cheap. The issue reporter is a packager for Fedora so I like to make their life easier. (Maybe add "Fixes #1234." to the PR description?) |
e0513d3
to
ee55929
Compare
Okay, do you want to take care of the release? I've invited you to the Packagers team, which should give you privileges to publish to crates.io. Do the following things:
|
Thank you! First time, I'll be careful. |
Published. |
It only fails with the
unstable-locales
feature.Fixes #1234.