Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_type_types on 32-bit targets #1235

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

pitdicker
Copy link
Collaborator

@pitdicker pitdicker commented Aug 30, 2023

It only fails with the unstable-locales feature.

Fixes #1234.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1235 (e0513d3) into main (b6a5244) will increase coverage by 0.22%.
Report is 93 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head e0513d3 differs from pull request most recent head ee55929. Consider uploading reports for the commit ee55929 to get more accurate results

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   86.10%   86.32%   +0.22%     
==========================================
  Files          37       35       -2     
  Lines       13522    13896     +374     
==========================================
+ Hits        11643    11996     +353     
- Misses       1879     1900      +21     
Files Changed Coverage Δ
src/format/strftime.rs 98.94% <100.00%> (+<0.01%) ⬆️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to put a version bump in there?

@pitdicker
Copy link
Collaborator Author

pitdicker commented Aug 30, 2023

Do you think this warrants a new release already? (because it is a test, and only behind the unstable-locales feature)
Edit: I have a commit with the version bump ready.

@djc
Copy link
Member

djc commented Aug 30, 2023

Semver-compatible releases are cheap. The issue reporter is a packager for Fedora so I like to make their life easier.

(Maybe add "Fixes #1234." to the PR description?)

@pitdicker pitdicker changed the base branch from main to 0.4.x August 30, 2023 19:20
@pitdicker pitdicker merged commit 243d26d into chronotope:0.4.x Aug 30, 2023
@pitdicker pitdicker deleted the fix_test_type_sizes branch August 30, 2023 19:28
@djc
Copy link
Member

djc commented Aug 30, 2023

Okay, do you want to take care of the release? I've invited you to the Packagers team, which should give you privileges to publish to crates.io. Do the following things:

  • Checkout 0.4.x
  • Pull so you have the latest changes
  • Run cargo publish
  • Run git tag -am "Tag version 0.4.28" v0.4.28
  • Run git push --tags
  • Publish release notes
  • Post in the release prep PR that it's published.

@pitdicker
Copy link
Collaborator Author

Thank you! First time, I'll be careful.

@pitdicker
Copy link
Collaborator Author

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants