Clarify Timelike::num_seconds_from_midnight is a simple mapping
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1255 +/- ##
==========================================
- Coverage 91.41% 91.37% -0.04%
==========================================
Files 37 37
Lines 16452 16448 -4
==========================================
- Hits 15040 15030 -10
- Misses 1412 1418 +6
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
reviewed
Sep 6, 2023
src/traits.rs
Outdated
| /// Every value in 00:00:00-23:59:59 maps to an integer in 0-86399. | ||
| /// | ||
| /// This method is not intended to provide the real number of seconds since midnight on a given | ||
| /// day. It does not take things into account such as a DST transition. |
There was a problem hiding this comment.
The last sentence feels a bit awkward? I'd rewrite this last sentence as "It does not take things like DST transitions into account.", what do you think?
There was a problem hiding this comment.
Yes, that is better 👍
pitdicker
force-pushed
the
num_seconds_from_midnight_doc
branch
from
90a7f8a to
8f118fe
Compare
djc
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.