Remove __doctest feature and doc_comment dependency
#1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1276 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 38 38
Lines 16932 16932
=======================================
Hits 15477 15477
Misses 1455 1455
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__doctestfeature anddoc_commentdependency where added in #316 to test the examples inREADME.md. But we no longer use it for testing, and don't have examples in the README.I propose to just remove this feature. The
__doctestname should have made it pretty clear this was not mean to be a feature other crates should rely on.