Add time zone timestamp micros #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaiveDateTime::from_timestamp_millis to reduce code duplication
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.01%
==========================================
Files 35 35
Lines 16841 16860 +19
==========================================
+ Hits 15408 15425 +17
- Misses 1433 1435 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pitdicker
reviewed
Sep 12, 2023
src/offset/mod.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_micros_example() { |
There was a problem hiding this comment.
I don't think you need to copy the doctest here.
There was a problem hiding this comment.
Thanks, I wasn't aware this gets tested automatically :)
src/offset/mod.rs
Outdated
| /// | ||
| /// assert_eq!(Utc.timestamp_micros_opt(1431648000000).unwrap().timestamp(), 1431648); | ||
| /// ``` | ||
| fn timestamp_micros_opt(&self, micros: i64) -> LocalResult<DateTime<Self>> { |
There was a problem hiding this comment.
Can this also use NaiveTime::from_timestamp_micros?
@djc Do we want the _opt suffix?
There was a problem hiding this comment.
I tested using NaiveTime::from_timestamp_micros locally, it seems to work as expected.
Once we decide if you'll rather not have the _opt suffix, I'll push my changes.
pitdicker
approved these changes
Sep 13, 2023
Use NaiveDateTime::from_timestamp_micros instead of implementing the same logic again.
emikitas
force-pushed
the
add_TimeZone_timestamp_micros
branch
from
d9b3468 to
81708eb
Compare
djc
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
TimeZone::timestamp_micros_optand madeTimeZone::timestamp_millis_optuseNaiveDateTime::from_timestamp_millisto reduce logic duplication.resolves #1284