Document panics in Add
/Sub
impls and use expect
#1316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large but simple PR.
I made sure all
Add
/Sub
documentation onNaiveDate
,NaiveTime
,NaiveDateTime
andDateTime
follows the same format and mentions panics.The implementations now use
expect
instead of unwrap.And I changed
impl Add<std::time::Duration> for NaiveTime
andSub
to take a modulus of the duration before converting to remove a panic case.Fixes #1302, #1314.