Fix out of range panics in DateTime
getters and setters
#1317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #1048.
This PR only fixes the first group of methods: those that panic on an intermediate value, but should be able to return a meaningful result. This includes formatting, and getters and setters of the
Datelike
andTimelike
traits.I made
MIN_YEAR
andMAX_YEAR
1 year smaller to have some buffer space.DateTime::overflowing_naive_local
andNaiveDateTime::overflowing_add_offset
are added to create a value in that buffer space.The rest of the PR consists of just using these methods and adding tests.